Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] - add more coverage #194

Merged
merged 4 commits into from
Mar 16, 2024
Merged

[testing] - add more coverage #194

merged 4 commits into from
Mar 16, 2024

Conversation

AshleyDumaine
Copy link
Contributor

What type of PR is this?

/kind testing

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 28.80%. Comparing base (64dbda2) to head (97e7fe0).

Files Patch % Lines
cloud/services/loadbalancers.go 0.00% 4 Missing ⚠️
controller/linodemachine_controller.go 0.00% 4 Missing ⚠️
controller/linodevpc_controller_helpers.go 0.00% 4 Missing ⚠️
util/filter.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   27.60%   28.80%   +1.19%     
==========================================
  Files          27       25       -2     
  Lines        1985     1302     -683     
==========================================
- Hits          548      375     -173     
+ Misses       1384      904     -480     
+ Partials       53       23      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshleyDumaine AshleyDumaine force-pushed the test-improvements branch 3 times, most recently from 1c6da3b to 123a51f Compare March 14, 2024 16:39
@AshleyDumaine AshleyDumaine changed the title [testing] - add tests for filter.go and version.go [testing] - add more coverage Mar 14, 2024
@AshleyDumaine AshleyDumaine force-pushed the test-improvements branch 2 times, most recently from 9bc1b24 to 97e7fe0 Compare March 14, 2024 20:45
@AshleyDumaine AshleyDumaine merged commit 0e49a25 into main Mar 16, 2024
12 of 13 checks passed
@AshleyDumaine AshleyDumaine deleted the test-improvements branch March 16, 2024 01:05
amold1 pushed a commit that referenced this pull request May 17, 2024
* add tests for filter and version

* exclude mock package from coverage since it's autogenerated

* add helpers test

* exclude autogenerated deepcopy from coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants